Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.3 #457

Merged
merged 7 commits into from
Apr 29, 2023
Merged

v5.0.3 #457

merged 7 commits into from
Apr 29, 2023

Conversation

AdhocAdam
Copy link
Owner

@AdhocAdam AdhocAdam commented Apr 25, 2023

  • 🐛 Fixes an issue with Templates that contain nested Activities (e.g. a Service Request Template that contains a Sequential/Parallel Activity that contains other Activities)
  • 🐛Fixes an issue when leaving a comment that is greater than 4,000 characters
  • 🐛Fixes an issue wherein Custom Events requires verbose logging (i.e. 4) to properly load
  • 💡 Merge Reply functionality has been extended to support 12 additional language Reply patterns (AW, SV, Antw, REF, RIF, SV, BLS, Atb., RES, Odp, YNT, ATB)

To do:

  • Testing
  • Review
  • Update inline PowerShell notes
    • version and change notes
    • update contributors

SimonZein and others added 4 commits March 21, 2023 21:27
Added -Alias $alias to the recursive Update-SCSMPropertyCollection call
Whenever the update-workitem is called with a message, where the length of the body is greater than 4000, the substring(0,4000) function is called, but the result is not written back to the commentToAdd variable - so the full message is further processed, and the action log is not added to the workitem.
…ge Regex (#453)

* Update smletsExchangeConnector.ps1

* Update smletsExchangeConnector.ps1

* update reply regex

adding square brackets to two of the reply regexes to be consistent with the rest of the patterns

---------

Co-authored-by: Adam <adhocadam@protonmail.com>
$true/$false values are incorrectly tied to the logging level used by the connector. This moves them out of that logic and ensures $ceScripts always has a value
@AdhocAdam AdhocAdam added this to the 5.x.x milestone Apr 25, 2023
@AdhocAdam AdhocAdam self-assigned this Apr 25, 2023
@AdhocAdam
Copy link
Owner Author

Didn't catch it on the original pull @SimonZein, but for the sake of being cautious and not holding the release, I'm going to remove the single regex of ([V][á][:]) that you provided on #453 as PSScriptAnalyzer is throwing a Warning on it.

RuleName : PSUseBOMForUnicodeEncodedFile
Message : Missing BOM encoding for non-ASCII encoded file 'smletsExchangeConnector.ps1'

Per PSScriptAnalyzer, this specific regex reply pattern is throwing a warning. It's possible this can be overcome, but short of further research/holding the release it's going to be removed for now. https://learn.microsoft.com/en-us/powershell/utility-modules/psscriptanalyzer/rules/usebomforunicodeencodedfile?view=ps-modules
* powershell contributors

updating powershell contributor list per pull requests/commits

* update contributors on AboutForm.xaml

updating the contributor list per pull requests/commits
@AdhocAdam AdhocAdam changed the title 5.0.3 v5.0.3 Apr 26, 2023
updating inline version notes with relevant issues/pull requests
@AdhocAdam AdhocAdam marked this pull request as ready for review April 29, 2023 17:37
@AdhocAdam AdhocAdam merged commit 860b095 into primary Apr 29, 2023
6 checks passed
@AdhocAdam AdhocAdam deleted the dev branch June 6, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants